New CodeQL codemod for mitigating Regex DoS #484
Open
andrecsilva wants to merge 4 commits intomainfrom
Open
Conversation
andrecsilva
force-pushed
the
ISS-2495/codeql-regex-dos
branch
from
1015216 to
6599c3e
Compare
nahsra
requested changes
Dec 10, 2024
Contributor
nahsra
left a comment
nahsra
left a comment
There was a problem hiding this comment.
This is a complicated change that will be repeated many times in the codebase. Is there any chance we can get a function like this in the codebase, or add it to the java security toolkit?
If it’s something that must be delivered inline, we should have unit tests that test the code we insert to make sure it’s doing what we think it’s doing.
andrecsilva
force-pushed
the
ISS-2495/codeql-regex-dos
branch
from
48c961a to
b8b90cd
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
\close #work